ci: improve pr quality workflow (#8374)

.github/workflows/chore-remove-labels-and-assignees-on-close.yml

@@ -1,86 +0,0 @@
-name: Remove Labels and Assignees on Issue Close
-
-on:
-  issues:
-    types: [closed]
-  pull_request:
-    types: [closed]
-  pull_request_target:
-    types: [closed]
-
-permissions:
-  issues: write
-  pull-requests: write
-
-jobs:
-  remove-labels-and-assignees:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Remove labels and assignees
-        uses: actions/github-script@v7
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            const { owner, repo } = context.repo;
-
-            async function processIssue(issueNumber, isFromPR = false, prBaseBranch = null) {
-              try {
-                if (isFromPR && prBaseBranch !== 'v4.x') {
-                  return;
-                }
-
-                const { data: currentLabels } = await github.rest.issues.listLabelsOnIssue({
-                  owner,
-                  repo,
-                  issue_number: issueNumber
-                });
-
-                const labelsToKeep = currentLabels
-                  .filter(label => label.name === '⏱︎ Stale')
-                  .map(label => label.name);
-
-                await github.rest.issues.setLabels({
-                  owner,
-                  repo,
-                  issue_number: issueNumber,
-                  labels: labelsToKeep
-                });
-
-                const { data: issue } = await github.rest.issues.get({
-                  owner,
-                  repo,
-                  issue_number: issueNumber
-                });
-
-                if (issue.assignees && issue.assignees.length > 0) {
-                  await github.rest.issues.removeAssignees({
-                    owner,
-                    repo,
-                    issue_number: issueNumber,
-                    assignees: issue.assignees.map(assignee => assignee.login)
-                  });
-                }
-              } catch (error) {
-                if (error.status !== 404) {
-                  console.error(`Error processing issue ${issueNumber}:`, error);
-                }
-              }
-            }
-
-            if (context.eventName === 'issues') {
-              await processIssue(context.payload.issue.number);
-            }
-
-            if (context.eventName === 'pull_request' || context.eventName === 'pull_request_target') {
-              const pr = context.payload.pull_request;
-              await processIssue(pr.number);
-              if (pr.merged && pr.base.ref === 'v4.x' && pr.body) {
-                const issueReferences = pr.body.match(/#(\d+)/g);
-                if (issueReferences) {
-                  for (const reference of issueReferences) {
-                    const issueNumber = parseInt(reference.substring(1));
-                    await processIssue(issueNumber, true, pr.base.ref);
-                  }
-                }
-              }
-            }

.github/workflows/pr-quality.yaml

@@ -56,7 +56,10 @@ jobs:
             SECURITY.md
             LICENSE
             CODE_OF_CONDUCT.md
+            templates/service-templates-latest.json
+            templates/service-templates.json
           require-final-newline: true
+
           # User Health Checks
           min-repo-merged-prs: 0
           min-repo-merge-ratio: 0
@@ -73,7 +76,7 @@ jobs:
             renovate[bot]
             github-actions[bot]
           exempt-draft-prs: false
-          exempt-label: "status/exempt"
+          exempt-label: "quality/exempt"
           exempt-pr-label: ""
           exempt-milestones: ""
           exempt-pr-milestones: ""
@@ -81,7 +84,7 @@ jobs:
           exempt-all-pr-milestones: false
 
           # PR Success Actions
-          success-add-pr-labels: "status/verified"
+          success-add-pr-labels: "quality/verified"
 
           # PR Failure Actions
           close-pr: true
@@ -90,4 +93,4 @@ jobs:
           failure-pr-message: "This PR did not pass quality checks so it will be closed. If you believe this is a mistake please let us know."
           failure-remove-pr-labels: ""
           failure-remove-all-pr-labels: true
-          failure-add-pr-labels: ""
+          failure-add-pr-labels: "quality/rejected"