fix(validation): add input validation for sentinel configuration (#9243)

This commit is contained in:
Andras Bacsai 2026-03-30 21:00:18 +02:00 committed by GitHub
commit 0b9d2c9e11
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 6 deletions

View file

@ -25,13 +25,13 @@ class Sentinel extends Component
public ?string $sentinelUpdatedAt = null; public ?string $sentinelUpdatedAt = null;
#[Validate(['required', 'integer', 'min:1'])] #[Validate(['required', 'integer', 'min:1'])]
public int $sentinelMetricsRefreshRateSeconds; public int|string $sentinelMetricsRefreshRateSeconds;
#[Validate(['required', 'integer', 'min:1'])] #[Validate(['required', 'integer', 'min:1'])]
public int $sentinelMetricsHistoryDays; public int|string $sentinelMetricsHistoryDays;
#[Validate(['required', 'integer', 'min:10'])] #[Validate(['required', 'integer', 'min:10'])]
public int $sentinelPushIntervalSeconds; public int|string $sentinelPushIntervalSeconds;
#[Validate(['nullable', 'url'])] #[Validate(['nullable', 'url'])]
public ?string $sentinelCustomUrl = null; public ?string $sentinelCustomUrl = null;

View file

@ -91,13 +91,14 @@
<div class="flex flex-col gap-2"> <div class="flex flex-col gap-2">
<div class="flex flex-wrap gap-2 sm:flex-nowrap"> <div class="flex flex-wrap gap-2 sm:flex-nowrap">
<x-forms.input canGate="update" :canResource="$server" <x-forms.input canGate="update" :canResource="$server" type="number" min="1"
id="sentinelMetricsRefreshRateSeconds" label="Metrics rate (seconds)" required id="sentinelMetricsRefreshRateSeconds" label="Metrics rate (seconds)" required
helper="Interval used for gathering metrics. Lower values result in more disk space usage." /> helper="Interval used for gathering metrics. Lower values result in more disk space usage." />
<x-forms.input canGate="update" :canResource="$server" id="sentinelMetricsHistoryDays" <x-forms.input canGate="update" :canResource="$server" type="number" min="1"
id="sentinelMetricsHistoryDays"
label="Metrics history (days)" required label="Metrics history (days)" required
helper="Number of days to retain metrics data for." /> helper="Number of days to retain metrics data for." />
<x-forms.input canGate="update" :canResource="$server" <x-forms.input canGate="update" :canResource="$server" type="number" min="10"
id="sentinelPushIntervalSeconds" label="Push interval (seconds)" required id="sentinelPushIntervalSeconds" label="Push interval (seconds)" required
helper="Interval at which metrics data is sent to the collector." /> helper="Interval at which metrics data is sent to the collector." />
</div> </div>