From 0cc59739015732baa25593860164c90eae0d0bef Mon Sep 17 00:00:00 2001
From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com>
Date: Fri, 5 Dec 2025 11:48:42 +0100
Subject: [PATCH] Disable rollback for non-commit image tags (e.g., 'latest')
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Existing Docker Compose deployments may have 'latest' or custom tags
that aren't valid git commit SHAs. When rollback is triggered with these
tags, the deployment fails because the system tries to use the tag as a
git commit reference.

This change:
- Detects if image tag is a valid commit SHA or PR tag
- Disables rollback button for non-commit tags with helpful tooltip
- Displays appropriate label (SHA/PR/Tag) based on tag type
- Guides users to re-deploy to create rollback-enabled images

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 .../project/application/rollback.blade.php    | 27 ++++++++++++++-----
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/resources/views/livewire/project/application/rollback.blade.php b/resources/views/livewire/project/application/rollback.blade.php
index 02f7d14b2..07ca40c56 100644
--- a/resources/views/livewire/project/application/rollback.blade.php
+++ b/resources/views/livewire/project/application/rollback.blade.php
@@ -21,18 +21,29 @@
                 <div class="w-2/4 p-2">
                     <div
                         class="bg-white border rounded-sm dark:border-coolgray-300 dark:bg-coolgray-100 border-neutral-200">
+                        @php
+                            $tag = data_get($image, 'tag');
+                            $date = data_get($image, 'created_at');
+                            $interval = \Illuminate\Support\Carbon::parse($date);
+                            // Check if tag looks like a commit SHA (hex string) or PR tag (pr-N)
+                            $isCommitSha = preg_match('/^[0-9a-f]{7,128}$/i', $tag);
+                            $isPrTag = preg_match('/^pr-\d+$/', $tag);
+                            $isRollbackable = $isCommitSha || $isPrTag;
+                        @endphp
                         <div class="p-2">
                             <div class="">
                                 @if (data_get($image, 'is_current'))
                                     <span class="font-bold dark:text-warning">LIVE</span>
                                     |
                                 @endif
-                                SHA: {{ data_get($image, 'tag') }}
+                                @if ($isCommitSha)
+                                    SHA: {{ $tag }}
+                                @elseif ($isPrTag)
+                                    PR: {{ $tag }}
+                                @else
+                                    Tag: {{ $tag }}
+                                @endif
                             </div>
-                            @php
-                                $date = data_get($image, 'created_at');
-                                $interval = \Illuminate\Support\Carbon::parse($date);
-                            @endphp
                             <div class="text-xs">{{ $interval->diffForHumans() }}</div>
                             <div class="text-xs">{{ $date }}</div>
                         </div>
@@ -42,9 +53,13 @@ class="bg-white border rounded-sm dark:border-coolgray-300 dark:bg-coolgray-100
                                     <x-forms.button disabled tooltip="This image is currently running.">
                                         Rollback
                                     </x-forms.button>
+                                @elseif (!$isRollbackable)
+                                    <x-forms.button disabled tooltip="Rollback not available for '{{ $tag }}' tag. Only commit-based tags support rollback. Re-deploy to create a rollback-enabled image.">
+                                        Rollback
+                                    </x-forms.button>
                                 @else
                                     <x-forms.button class="dark:bg-coolgray-100"
-                                        wire:click="rollbackImage('{{ data_get($image, 'tag') }}')">
+                                        wire:click="rollbackImage('{{ $tag }}')">
                                         Rollback
                                     </x-forms.button>
                                 @endif