rosslh/coolify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: cleanup scheduled tasks

Browse source
This commit is contained in:
Andras Bacsai 2024-02-14 15:14:06 +01:00
parent 8f21ea9367
commit 1f18542960
5 changed files with 21 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/Actions/Service/DeleteService.php
View file

@ -45,6 +45,9 @@ public function handle(Service $service)
foreach ($service->databases()->get() as $database) {
$database->forceDelete();
}
foreach ($service->scheduled_tasks as $task) {
$task->delete();
}
$service->tags()->detach();
}
}

12
app/Console/Commands/CleanupStuckedResources.php
View file

@ -3,6 +3,7 @@
namespace App\Console\Commands;
use App\Models\Application;
use App\Models\ScheduledTask;
use App\Models\Service;
use App\Models\ServiceApplication;
use App\Models\ServiceDatabase;
@ -108,6 +109,17 @@ private function cleanup_stucked_resources()
} catch (\Throwable $e) {
echo "Error in cleaning stuck serviceapp: {$e->getMessage()}\n";
}
try {
$scheduled_tasks = ScheduledTask::all();
foreach ($scheduled_tasks as $scheduled_task) {
if (!$scheduled_task->service && !$scheduled_task->application) {
echo "Deleting stuck scheduledtask: {$scheduled_task->name}\n";
$scheduled_task->delete();
}
}
} catch (\Throwable $e) {
echo "Error in cleaning stuck scheduledtasks: {$e->getMessage()}\n";
}
// Cleanup any resources that are not attached to any environment or destination or server
try {

4
app/Console/Kernel.php
View file

@ -120,8 +120,8 @@ private function check_scheduled_tasks($schedule)
return;
}
foreach ($scheduled_tasks as $scheduled_task) {
$service = $scheduled_task->service()->first();
$application = $scheduled_task->application()->first();
$service = $scheduled_task->service;
$application = $scheduled_task->application;
if (!$application && !$service) {
ray('application/service attached to scheduled task does not exist');

3
app/Models/Application.php
View file

@ -48,6 +48,9 @@ protected static function booted()
$application->persistentStorages()->delete();
$application->environment_variables()->delete();
$application->environment_variables_preview()->delete();
foreach ($application->scheduled_tasks as $task) {
$task->delete();
}
$application->tags()->detach();
});
}

2
resources/views/livewire/project/shared/scheduled-task/show.blade.php
View file

@ -28,7 +28,7 @@
</form>
<div class="pt-4">
<h3 class="py-4">Recent executions</h3>
<h3 class="py-4">Recent executions <span class="text-xs text-neutral-500">(click to check output)</span></h3>
<livewire:project.shared.scheduled-task.executions key="{{ $task->id }}" selectedKey="" :executions="$task->executions->take(-20)" />
</div>
</div>