rosslh/coolify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove duplicate getArchDockerInstallCommand() method

Browse source 
The method was defined twice with the first (outdated) definition using
-Syyy and lacking proper flags. Keep the improved version that uses -Syu
with --needed for idempotency and proper systemctl ordering.
This commit is contained in:
Andras Bacsai 2025-12-11 09:25:35 +01:00
parent 0e6a2fc15d
commit 206a9c03d2
1 changed files with 5 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
app/Actions/Server/InstallDocker.php
View file

@ -148,19 +148,6 @@ private function getSuseDockerInstallCommand(): string
')'; ')';
} }
private function getArchDockerInstallCommand(): string
{
return 'pacman -Syyy --noconfirm && '.
'pacman -S docker docker-compose --noconfirm && '.
'systemctl start docker && '.
'systemctl enable docker';
}
private function getGenericDockerInstallCommand(): string
{
return "curl https://releases.rancher.com/install-docker/{$this->dockerVersion}.sh | sh || curl https://get.docker.com | sh -s -- --version {$this->dockerVersion}";
}
private function getArchDockerInstallCommand(): string private function getArchDockerInstallCommand(): string
{ {
// Use -Syu to perform full system upgrade before installing Docker // Use -Syu to perform full system upgrade before installing Docker
@ -171,4 +158,9 @@ private function getArchDockerInstallCommand(): string
'systemctl enable docker.service && '. 'systemctl enable docker.service && '.
'systemctl start docker.service'; 'systemctl start docker.service';
} }
private function getGenericDockerInstallCommand(): string
{
return "curl https://releases.rancher.com/install-docker/{$this->dockerVersion}.sh | sh || curl https://get.docker.com | sh -s -- --version {$this->dockerVersion}";
}
} }