From 38aaf8cb2a029a25dc89954b7d3dd97fac192687 Mon Sep 17 00:00:00 2001
From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com>
Date: Wed, 19 Aug 2026 12:31:36 +0200
Subject: [PATCH] fix(caddy): prevent exact label generation argument error
 (#11397)

---
 app/Models/Application.php                    |  6 ++-
 bootstrap/helpers/docker.php                  |  1 -
 database/factories/ApplicationFactory.php     |  4 ++
 .../CaddyApplicationLabelGenerationTest.php   | 38 +++++++++++++++++++
 4 files changed, 47 insertions(+), 2 deletions(-)
 create mode 100644 tests/Feature/CaddyApplicationLabelGenerationTest.php

diff --git a/app/Models/Application.php b/app/Models/Application.php
index fef76cd39..0868bdf9c 100644
--- a/app/Models/Application.php
+++ b/app/Models/Application.php
@@ -12,6 +12,7 @@
 use App\Traits\HasMetrics;
 use App\Traits\HasNoindexDomains;
 use App\Traits\HasSafeStringAttribute;
+use Database\Factories\ApplicationFactory;
 use Illuminate\Database\Eloquent\Casts\Attribute;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Relations\HasMany;
@@ -120,7 +121,10 @@
 
 class Application extends BaseModel
 {
-    use ClearsGlobalSearchCache, HasConfiguration, HasFactory, HasMetrics, HasNoindexDomains, HasSafeStringAttribute, SoftDeletes;
+    use ClearsGlobalSearchCache, HasConfiguration, HasMetrics, HasNoindexDomains, HasSafeStringAttribute, SoftDeletes;
+
+    /** @use HasFactory<ApplicationFactory> */
+    use HasFactory;
 
     public const MAX_DOCKER_COMPOSE_SIZE_BYTES = 5 * 1024 * 1024;
 
diff --git a/bootstrap/helpers/docker.php b/bootstrap/helpers/docker.php
index a60ba675b..210c84a86 100644
--- a/bootstrap/helpers/docker.php
+++ b/bootstrap/helpers/docker.php
@@ -891,7 +891,6 @@ function generateLabelsApplication(Application $application, ?ApplicationPreview
                             http_basic_auth_username: $application->http_basic_auth_username,
                             http_basic_auth_password: $application->http_basic_auth_password,
                             noindex_domains: $noindexDomains,
-                            escape_redirect_replacement_for_compose: false,
                         ));
                         break;
                 }
diff --git a/database/factories/ApplicationFactory.php b/database/factories/ApplicationFactory.php
index ded507c56..188d32954 100644
--- a/database/factories/ApplicationFactory.php
+++ b/database/factories/ApplicationFactory.php
@@ -2,8 +2,12 @@
 
 namespace Database\Factories;
 
+use App\Models\Application;
 use Illuminate\Database\Eloquent\Factories\Factory;
 
+/**
+ * @extends Factory<Application>
+ */
 class ApplicationFactory extends Factory
 {
     public function definition(): array
diff --git a/tests/Feature/CaddyApplicationLabelGenerationTest.php b/tests/Feature/CaddyApplicationLabelGenerationTest.php
new file mode 100644
index 000000000..b31fa29a4
--- /dev/null
+++ b/tests/Feature/CaddyApplicationLabelGenerationTest.php
@@ -0,0 +1,38 @@
+<?php
+
+use App\Enums\ProxyTypes;
+use App\Models\Application;
+use App\Models\Environment;
+use App\Models\Project;
+use App\Models\Server;
+use App\Models\StandaloneDocker;
+use App\Models\Team;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+test('generates exact Caddy labels for an application with a domain', function () {
+    $team = Team::factory()->create();
+    $project = Project::factory()->create(['team_id' => $team->id]);
+    $environment = Environment::factory()->create(['project_id' => $project->id]);
+    $server = Server::factory()->create([
+        'team_id' => $team->id,
+        'proxy' => ['type' => ProxyTypes::CADDY->value],
+    ]);
+    $server->settings->update(['generate_exact_labels' => true]);
+    $destination = StandaloneDocker::query()->where('server_id', $server->id)->firstOrFail();
+    $application = Application::factory()->createOne([
+        'environment_id' => $environment->id,
+        'destination_id' => $destination->id,
+        'destination_type' => $destination->getMorphClass(),
+        'fqdn' => 'https://example.com',
+        'redirect' => 'both',
+        'is_http_basic_auth_enabled' => false,
+    ]);
+
+    $labels = generateLabelsApplication($application);
+
+    expect($labels)
+        ->toContain('caddy_ingress_network=coolify')
+        ->not->toContain('traefik.enable=true');
+});