rosslh/coolify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(applications): treat zero private_key_id as deploy key (#8563)

Browse source
This commit is contained in:
Andras Bacsai 2026-02-23 14:16:11 +01:00 committed by GitHub
commit 46923f7e77
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/Models/Application.php
View file

@ -990,7 +990,7 @@ public function deploymentType()
if (isDev() && data_get($this, 'private_key_id') === 0) { if (isDev() && data_get($this, 'private_key_id') === 0) {
return 'deploy_key'; return 'deploy_key';
} }
if (data_get($this, 'private_key_id')) { if (! is_null(data_get($this, 'private_key_id'))) {
return 'deploy_key'; return 'deploy_key';
} elseif (data_get($this, 'source')) { } elseif (data_get($this, 'source')) {
return 'source'; return 'source';

11
tests/Unit/ApplicationDeploymentTypeTest.php Normal file
View file

@ -0,0 +1,11 @@
<?php
use App\Models\Application;
it('treats zero private key id as deploy key', function () {
$application = new Application();
$application->private_key_id = 0;
$application->source = null;
expect($application->deploymentType())->toBe('deploy_key');
});