rosslh/coolify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(clone): include uuid field when cloning persistent volumes

Browse source 
Ensure that the uuid field is preserved during clone operations for persistent
volumes across all clone methods (CloneMe, ResourceOperations, and the clone_application
helper). This prevents UUID conflicts and ensures cloned volumes receive new unique
identifiers as intended.

Adds test coverage validating that cloned persistent volumes receive new UUIDs
distinct from the original volumes.
This commit is contained in:
Andras Bacsai 2026-03-30 00:06:45 +02:00
parent 9ccdbf66b0
commit 4ec9b7ef69
4 changed files with 91 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/Livewire/Project/CloneMe.php
View file

@ -187,6 +187,7 @@ public function clone(string $type)
'id',
'created_at',
'updated_at',
'uuid',
])->forceFill([
'name' => $newName,
'resource_id' => $newDatabase->id,
@ -315,6 +316,7 @@ public function clone(string $type)
'id',
'created_at',
'updated_at',
'uuid',
])->forceFill([
'name' => $newName,
'resource_id' => $application->id,
@ -369,6 +371,7 @@ public function clone(string $type)
'id',
'created_at',
'updated_at',
'uuid',
])->forceFill([
'name' => $newName,
'resource_id' => $database->id,

3
app/Livewire/Project/Shared/ResourceOperations.php
View file

@ -142,6 +142,7 @@ public function cloneTo($destination_id)
'id',
'created_at',
'updated_at',
'uuid',
])->forceFill([
'name' => $newName,
'resource_id' => $new_resource->id,
@ -280,6 +281,7 @@ public function cloneTo($destination_id)
'id',
'created_at',
'updated_at',
'uuid',
])->forceFill([
'name' => $newName,
'resource_id' => $application->id,
@ -322,6 +324,7 @@ public function cloneTo($destination_id)
'id',
'created_at',
'updated_at',
'uuid',
])->forceFill([
'name' => $newName,
'resource_id' => $database->id,

1
bootstrap/helpers/applications.php
View file

@ -300,6 +300,7 @@ function clone_application(Application $source, $destination, array $overrides =
'id',
'created_at',
'updated_at',
'uuid',
])->fill([
'name' => $newName,
'resource_id' => $newApplication->id,

84
tests/Feature/ClonePersistentVolumeUuidTest.php Normal file
View file

@ -0,0 +1,84 @@
<?php
use App\Livewire\Project\Shared\ResourceOperations;
use App\Models\Application;
use App\Models\Environment;
use App\Models\LocalPersistentVolume;
use App\Models\Project;
use App\Models\Server;
use App\Models\StandaloneDocker;
use App\Models\Team;
use App\Models\User;
use Livewire\Livewire;
beforeEach(function () {
$this->user = User::factory()->create();
$this->team = Team::factory()->create();
$this->user->teams()->attach($this->team, ['role' => 'owner']);
$this->server = Server::factory()->create(['team_id' => $this->team->id]);
$this->destination = StandaloneDocker::factory()->create(['server_id' => $this->server->id]);
$this->project = Project::factory()->create(['team_id' => $this->team->id]);
$this->environment = Environment::factory()->create(['project_id' => $this->project->id]);
$this->application = Application::factory()->create([
'environment_id' => $this->environment->id,
'destination_id' => $this->destination->id,
'destination_type' => $this->destination->getMorphClass(),
]);
$this->actingAs($this->user);
session(['currentTeam' => $this->team]);
});
test('cloning application generates new uuid for persistent volumes', function () {
$volume = LocalPersistentVolume::create([
'name' => $this->application->uuid.'-data',
'mount_path' => '/data',
'resource_id' => $this->application->id,
'resource_type' => $this->application->getMorphClass(),
]);
$originalUuid = $volume->uuid;
$newApp = clone_application($this->application, $this->destination, [
'environment_id' => $this->environment->id,
]);
$clonedVolume = $newApp->persistentStorages()->first();
expect($clonedVolume)->not->toBeNull();
expect($clonedVolume->uuid)->not->toBe($originalUuid);
expect($clonedVolume->mount_path)->toBe('/data');
});
test('cloning application with multiple persistent volumes generates unique uuids', function () {
$volume1 = LocalPersistentVolume::create([
'name' => $this->application->uuid.'-data',
'mount_path' => '/data',
'resource_id' => $this->application->id,
'resource_type' => $this->application->getMorphClass(),
]);
$volume2 = LocalPersistentVolume::create([
'name' => $this->application->uuid.'-config',
'mount_path' => '/config',
'resource_id' => $this->application->id,
'resource_type' => $this->application->getMorphClass(),
]);
$newApp = clone_application($this->application, $this->destination, [
'environment_id' => $this->environment->id,
]);
$clonedVolumes = $newApp->persistentStorages()->get();
expect($clonedVolumes)->toHaveCount(2);
$clonedUuids = $clonedVolumes->pluck('uuid')->toArray();
$originalUuids = [$volume1->uuid, $volume2->uuid];
// All cloned UUIDs should be unique and different from originals
expect($clonedUuids)->each->not->toBeIn($originalUuids);
expect(array_unique($clonedUuids))->toHaveCount(2);
});