From 56394ba093ca82d99f9847edfbbaafe55d34a140 Mon Sep 17 00:00:00 2001 From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com> Date: Wed, 10 Dec 2025 13:22:53 +0100 Subject: [PATCH] fix: return actual error message from token validation endpoint MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Return the specific error from validateProviderToken() instead of generic "Failed to validate token." message - Update test to expect the actual error message 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- app/Http/Controllers/Api/CloudProviderTokensController.php | 2 +- tests/Feature/CloudProviderTokenApiTest.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/Api/CloudProviderTokensController.php b/app/Http/Controllers/Api/CloudProviderTokensController.php index 8bcedbe9c..5a03fe59a 100644 --- a/app/Http/Controllers/Api/CloudProviderTokensController.php +++ b/app/Http/Controllers/Api/CloudProviderTokensController.php @@ -525,7 +525,7 @@ public function validateToken(Request $request) return response()->json([ 'valid' => $validation['valid'], - 'message' => $validation['valid'] ? 'Token is valid.' : 'Failed to validate token.', + 'message' => $validation['valid'] ? 'Token is valid.' : $validation['error'], ]); } } diff --git a/tests/Feature/CloudProviderTokenApiTest.php b/tests/Feature/CloudProviderTokenApiTest.php index 8e87629f7..4623e0e96 100644 --- a/tests/Feature/CloudProviderTokenApiTest.php +++ b/tests/Feature/CloudProviderTokenApiTest.php @@ -386,7 +386,7 @@ ])->postJson("/api/v1/cloud-tokens/{$token->uuid}/validate"); $response->assertStatus(200); - $response->assertJson(['valid' => false, 'message' => 'Token is invalid.']); + $response->assertJson(['valid' => false, 'message' => 'Invalid hetzner token. Please check your API token.']); }); test('validates a valid DigitalOcean token', function () {