chore: prepare for PR
This commit is contained in:
parent
d9cdbc6096
commit
7aa744af90
1 changed files with 3 additions and 3 deletions
|
|
@ -2904,7 +2904,7 @@ private function wrap_build_command_with_env_export(string $build_command): stri
|
||||||
private function build_image()
|
private function build_image()
|
||||||
{
|
{
|
||||||
// Add Coolify related variables to the build args/secrets
|
// Add Coolify related variables to the build args/secrets
|
||||||
if (! $this->dockerBuildkitSupported) {
|
if (! $this->dockerSecretsSupported) {
|
||||||
// Traditional build args approach - generate COOLIFY_ variables locally
|
// Traditional build args approach - generate COOLIFY_ variables locally
|
||||||
$coolify_envs = $this->generate_coolify_env_variables(forBuildTime: true);
|
$coolify_envs = $this->generate_coolify_env_variables(forBuildTime: true);
|
||||||
$coolify_envs->each(function ($value, $key) {
|
$coolify_envs->each(function ($value, $key) {
|
||||||
|
|
@ -3515,8 +3515,8 @@ protected function findFromInstructionLines($dockerfile): array
|
||||||
|
|
||||||
private function add_build_env_variables_to_dockerfile()
|
private function add_build_env_variables_to_dockerfile()
|
||||||
{
|
{
|
||||||
if ($this->dockerBuildkitSupported) {
|
if ($this->dockerSecretsSupported) {
|
||||||
// We dont need to add build secrets to dockerfile for buildkit, as we already added them with --secret flag in function generate_docker_env_flags_for_secrets
|
// We dont need to add ARG declarations when using Docker build secrets, as variables are passed with --secret flag
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue