From 8408faf89765958861f8c5fde3be01ea7ccebfc5 Mon Sep 17 00:00:00 2001 From: Andras Bacsai <5845193+andrasbacsai@users.noreply.github.com> Date: Tue, 14 Oct 2025 11:05:42 +0200 Subject: [PATCH] Handle all ProcessStatus values in ApplicationPullRequestUpdateJob MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add support for QUEUED, KILLED, and CANCELLED statuses - Replace if-elseif chain with match expression for better exhaustiveness - Add appropriate emoji indicators for each status - Ensure all ProcessStatus enum values are handled 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- app/Jobs/ApplicationPullRequestUpdateJob.php | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/app/Jobs/ApplicationPullRequestUpdateJob.php b/app/Jobs/ApplicationPullRequestUpdateJob.php index 471edb4c6..a92f53b39 100755 --- a/app/Jobs/ApplicationPullRequestUpdateJob.php +++ b/app/Jobs/ApplicationPullRequestUpdateJob.php @@ -39,16 +39,17 @@ public function handle() $this->delete_comment(); return; - } elseif ($this->status === ProcessStatus::IN_PROGRESS) { - $this->body = "The preview deployment is in progress. 🟡\n\n"; - } elseif ($this->status === ProcessStatus::FINISHED) { - $this->body = "The preview deployment is ready. 🟢\n\n"; - if ($this->preview->fqdn) { - $this->body .= "[Open Preview]({$this->preview->fqdn}) | "; - } - } elseif ($this->status === ProcessStatus::ERROR) { - $this->body = "The preview deployment failed. 🔴\n\n"; } + + match ($this->status) { + ProcessStatus::QUEUED => $this->body = "The preview deployment is queued. ⏳\n\n", + ProcessStatus::IN_PROGRESS => $this->body = "The preview deployment is in progress. 🟡\n\n", + ProcessStatus::FINISHED => $this->body = "The preview deployment is ready. 🟢\n\n".($this->preview->fqdn ? "[Open Preview]({$this->preview->fqdn}) | " : ''), + ProcessStatus::ERROR => $this->body = "The preview deployment failed. 🔴\n\n", + ProcessStatus::KILLED => $this->body = "The preview deployment was killed. ⚫\n\n", + ProcessStatus::CANCELLED => $this->body = "The preview deployment was cancelled. 🚫\n\n", + ProcessStatus::CLOSED => '', // Already handled above, but included for completeness + }; $this->build_logs_url = base_url()."/project/{$this->application->environment->project->uuid}/environment/{$this->application->environment->uuid}/application/{$this->application->uuid}/deployment/{$this->deployment_uuid}"; $this->body .= '[Open Build Logs]('.$this->build_logs_url.")\n\n\n";