rosslh/coolify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(parsers): remove unused $svc variable in dockercompose domain loop

Browse source 
Use array_keys() instead of key-value iteration since only the service
name keys are needed for comparison. Addresses CodeRabbit review feedback.
This commit is contained in:
Tobias Thiele 2026-04-02 09:23:47 +02:00
parent 7f46b2ed71
commit 8b12aae266
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bootstrap/helpers/parsers.php
View file

@ -509,7 +509,7 @@ function applicationParser(Application $resource, int $pull_request_id = 0, ?int
if ($resource->build_pack === 'dockercompose') {
$normalizedFqdnFor = str($fqdnFor)->replace('-', '_')->replace('.', '_')->value();
$serviceExists = false;
foreach ($services as $serviceNameKey => $svc) {
foreach (array_keys($services) as $serviceNameKey) {
if (str($serviceNameKey)->replace('-', '_')->replace('.', '_')->value() === $normalizedFqdnFor) {
$serviceExists = true;
break;