rosslh/coolify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: invalid API response on missing project

Browse source 
API was returning 500 instead of 404 due to attempting to load environments for a non-existent project
This commit is contained in:
SierraJC 2024-12-14 12:52:47 +11:00
parent 8c07a36d9c
commit 9e8d9e6a9e
No known key found for this signature in database
GPG key ID: 464FEAD66F9DBC90
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/Http/Controllers/Api/ProjectController.php
View file

@ -90,11 +90,12 @@ public function project_by_uuid(Request $request)
if (is_null($teamId)) { if (is_null($teamId)) {
return invalidTokenResponse(); return invalidTokenResponse();
} }
$project = Project::whereTeamId($teamId)->whereUuid(request()->uuid)->first()->load(['environments']); $project = Project::whereTeamId($teamId)->whereUuid(request()->uuid)->first();
if (! $project) { if (! $project) {
return response()->json(['message' => 'Project not found.'], 404); return response()->json(['message' => 'Project not found.'], 404);
} }
$project->load(['environments']);
return response()->json( return response()->json(
serializeApiResponse($project), serializeApiResponse($project),
); );