rosslh/coolify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(sentinel): accept empty container heartbeats

Browse source 
Allow Sentinel pushes with an empty containers array so servers with no
running containers still refresh their heartbeat and enqueue an update.
This commit is contained in:
Andras Bacsai 2026-05-26 17:31:27 +02:00
parent 081bd6ef8c
commit 9f29df4cc3
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/Http/Controllers/Api/SentinelController.php
View file

@ -79,7 +79,7 @@ public function push(Request $request)
return response()->json(['message' => 'Unauthorized'], 401);
}
$validator = Validator::make($request->all(), [
'containers' => ['required', 'array', 'min:1'],
'containers' => ['present', 'array'],
]);
if ($validator->fails()) {

10
tests/Feature/SentinelPushDeduplicationTest.php
View file

@ -71,6 +71,15 @@ function sentinelPayload(array $containers, ?float $diskPercentage = 42.0): arra
expect(Carbon::parse($this->server->fresh()->sentinel_updated_at)->diffInSeconds(now()))->toBeLessThan(5);
});
it('accepts an empty container list as a heartbeat when no containers are running', function () {
$this->server->update(['sentinel_updated_at' => now()->subHour()]);
pushSentinel($this->token, sentinelPayload([]))->assertOk();
Queue::assertPushed(PushServerUpdateJob::class, 1);
expect(Carbon::parse($this->server->fresh()->sentinel_updated_at)->diffInSeconds(now()))->toBeLessThan(5);
});
it('rejects malformed sentinel payloads before touching server state', function (array $payload) {
$this->server->update(['sentinel_updated_at' => now()->subHour()]);
$originalHeartbeat = $this->server->fresh()->sentinel_updated_at;
@ -87,7 +96,6 @@ function sentinelPayload(array $containers, ?float $diskPercentage = 42.0): arra
})->with([
'missing containers' => [[]],
'non-array containers' => [['containers' => 'not-an-array']],
'empty containers' => [['containers' => []]],
]);
it('guards the dedupe decision with a server scoped atomic cache lock', function () {