rosslh/coolify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #6970 from coollabsio/andrasbacsai/readonly-compose-files

Browse source 
Fix: Remove content from docker_compose_raw to prevent file overwrites
This commit is contained in:
Andras Bacsai 2025-10-22 21:00:26 +02:00 committed by GitHub
commit dea8fdfb77
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
bootstrap/helpers/parsers.php
View file

@ -1297,7 +1297,11 @@ function applicationParser(Application $resource, int $pull_request_id = 0, ?int
return array_search($key, $customOrder); return array_search($key, $customOrder);
}); });
$resource->docker_compose = Yaml::dump(convertToArray($topLevel), 10, 2); $cleanedCompose = Yaml::dump(convertToArray($topLevel), 10, 2);
$resource->docker_compose = $cleanedCompose;
// Also update docker_compose_raw to remove content: from volumes
// This prevents content from being reapplied on subsequent deployments
$resource->docker_compose_raw = $cleanedCompose;
data_forget($resource, 'environment_variables'); data_forget($resource, 'environment_variables');
data_forget($resource, 'environment_variables_preview'); data_forget($resource, 'environment_variables_preview');
$resource->save(); $resource->save();
@ -2220,7 +2224,11 @@ function serviceParser(Service $resource): Collection
return array_search($key, $customOrder); return array_search($key, $customOrder);
}); });
$resource->docker_compose = Yaml::dump(convertToArray($topLevel), 10, 2); $cleanedCompose = Yaml::dump(convertToArray($topLevel), 10, 2);
$resource->docker_compose = $cleanedCompose;
// Also update docker_compose_raw to remove content: from volumes
// This prevents content from being reapplied on subsequent deployments
$resource->docker_compose_raw = $cleanedCompose;
data_forget($resource, 'environment_variables'); data_forget($resource, 'environment_variables');
data_forget($resource, 'environment_variables_preview'); data_forget($resource, 'environment_variables_preview');
$resource->save(); $resource->save();