docs(application): add comments explaining commit selection logic for rollback support
Add clarifying comments to the setGitImportSettings method explaining how the commit selection works, including the fallback to git_commit_sha and that invalid refs will cause failures on the remote server. This documents the behavior introduced for proper rollback commit handling. Also remove an extra blank line for minor code cleanup.
This commit is contained in:
parent
a71c16b17d
commit
e4fae68f0e
1 changed files with 2 additions and 1 deletions
|
|
@ -1093,6 +1093,8 @@ public function setGitImportSettings(string $deployment_uuid, string $git_clone_
|
|||
$escapedBaseDir = escapeshellarg($baseDir);
|
||||
$isShallowCloneEnabled = $this->settings?->is_git_shallow_clone_enabled ?? false;
|
||||
|
||||
// Use the explicitly passed commit (e.g. from rollback), falling back to the application's git_commit_sha.
|
||||
// Invalid refs will cause the git checkout/fetch command to fail on the remote server.
|
||||
$commitToUse = $commit ?? $this->git_commit_sha;
|
||||
|
||||
if ($commitToUse !== 'HEAD') {
|
||||
|
|
@ -1964,7 +1966,6 @@ public function parseHealthcheckFromDockerfile($dockerfile, bool $isInit = false
|
|||
}
|
||||
}
|
||||
|
||||
|
||||
public function getLimits(): array
|
||||
{
|
||||
return [
|
||||
|
|
|
|||
Loading…
Reference in a new issue