fix(api): handle JSON response in service creation and update methods for improved error handling
This commit is contained in:
parent
bb8cc467ab
commit
eee57d4c06
1 changed files with 6 additions and 1 deletions
|
|
@ -380,6 +380,9 @@ public function create_service(Request $request)
|
||||||
|
|
||||||
$service = new Service;
|
$service = new Service;
|
||||||
$result = $this->upsert_service($request, $service, $teamId);
|
$result = $this->upsert_service($request, $service, $teamId);
|
||||||
|
if ($result instanceof \Illuminate\Http\JsonResponse) {
|
||||||
|
return $result;
|
||||||
|
}
|
||||||
|
|
||||||
return response()->json(serializeApiResponse($result))->setStatusCode(201);
|
return response()->json(serializeApiResponse($result))->setStatusCode(201);
|
||||||
} else {
|
} else {
|
||||||
|
|
@ -608,12 +611,14 @@ public function update_by_uuid(Request $request)
|
||||||
}
|
}
|
||||||
|
|
||||||
$service = Service::whereRelation('environment.project.team', 'id', $teamId)->whereUuid($request->uuid)->first();
|
$service = Service::whereRelation('environment.project.team', 'id', $teamId)->whereUuid($request->uuid)->first();
|
||||||
|
|
||||||
if (! $service) {
|
if (! $service) {
|
||||||
return response()->json(['message' => 'Service not found.'], 404);
|
return response()->json(['message' => 'Service not found.'], 404);
|
||||||
}
|
}
|
||||||
|
|
||||||
$result = $this->upsert_service($request, $service, $teamId);
|
$result = $this->upsert_service($request, $service, $teamId);
|
||||||
|
if ($result instanceof \Illuminate\Http\JsonResponse) {
|
||||||
|
return $result;
|
||||||
|
}
|
||||||
|
|
||||||
return response()->json(serializeApiResponse($result))->setStatusCode(200);
|
return response()->json(serializeApiResponse($result))->setStatusCode(200);
|
||||||
}
|
}
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue