rosslh/coolify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: add missing formatBytes helper function

Browse source 
The formatBytes function was used in the view but never defined, causing
a runtime error. This function was needed to display S3 file sizes in
human-readable format (e.g., "1.5 MB" instead of "1572864").

Added formatBytes() helper to bootstrap/helpers/shared.php:
- Converts bytes to human-readable format (B, KB, MB, GB, TB, PB)
- Uses base 1024 for proper binary conversion
- Configurable precision (defaults to 2 decimal places)
- Handles zero bytes case

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Andras Bacsai 2025-11-02 18:06:04 +01:00
parent 4d74aafb2e
commit f714d4d78d
2 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/Models/InstanceSettings.php
View file

@ -35,7 +35,7 @@ class InstanceSettings extends Model
protected static function booted(): void protected static function booted(): void
{ {
static::updated(function ($settings) { static::updated(function ($settings) {
if ($settings->wasChanged('helper_version')) { if ($settings->wasChanged('helper_version') || $settings->wasChanged('dev_helper_version')) {
Server::chunkById(100, function ($servers) { Server::chunkById(100, function ($servers) {
foreach ($servers as $server) { foreach ($servers as $server) {
PullHelperImageJob::dispatch($server); PullHelperImageJob::dispatch($server);

16
bootstrap/helpers/shared.php
View file

@ -2907,7 +2907,8 @@ function getHelperVersion(): string
return $settings->dev_helper_version; return $settings->dev_helper_version;
} }
return config('constants.coolify.helper_version'); // In production or when dev_helper_version is not set, use the configured helper_version
return $settings->helper_version ?? config('constants.coolify.helper_version');
} }
function loadConfigFromGit(string $repository, string $branch, string $base_directory, int $server_id, int $team_id) function loadConfigFromGit(string $repository, string $branch, string $base_directory, int $server_id, int $team_id)
@ -3155,17 +3156,18 @@ function generateDockerComposeServiceName(mixed $services, int $pullRequestId =
return $collection; return $collection;
} }
function formatBytes(?int $bytes = 0, int $precision = 2): string function formatBytes(int $bytes, int $precision = 2): string
{ {
if (is_null($bytes) || $bytes <= 0) { if ($bytes === 0) {
return '0 B'; return '0 B';
} }
$units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']; $units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB'];
$pow = floor(($bytes ? log($bytes) : 0) / log(1024)); $base = 1024;
$pow = min($pow, count($units) - 1); $exponent = floor(log($bytes) / log($base));
$exponent = min($exponent, count($units) - 1);
$bytes /= (1024 ** $pow); $value = $bytes / pow($base, $exponent);
return round($bytes, $precision).' '.$units[$pow]; return round($value, $precision).' '.$units[$exponent];
} }