ffb5045c6a
Add `WithoutOverlapping` middleware to `DatabaseBackupJob` keyed by backup ID with timeout-based lock expiry to prevent concurrent runs. Mark long-running backup executions as failed when they exceed the stale time threshold, and add periodic retention enforcement in `CleanupInstanceStuffsJob` with cache-based throttling. Also add float casts for retention max-storage fields on `ScheduledDatabaseBackup` and comprehensive feature tests covering overlap middleware, stale detection, casts, and retention behavior.
82 lines
2.5 KiB
PHP
82 lines
2.5 KiB
PHP
<?php
|
|
|
|
namespace App\Jobs;
|
|
|
|
use App\Models\ScheduledDatabaseBackup;
|
|
use App\Models\TeamInvitation;
|
|
use App\Models\User;
|
|
use Illuminate\Bus\Queueable;
|
|
use Illuminate\Contracts\Queue\ShouldBeEncrypted;
|
|
use Illuminate\Contracts\Queue\ShouldBeUnique;
|
|
use Illuminate\Contracts\Queue\ShouldQueue;
|
|
use Illuminate\Foundation\Bus\Dispatchable;
|
|
use Illuminate\Queue\InteractsWithQueue;
|
|
use Illuminate\Queue\Middleware\WithoutOverlapping;
|
|
use Illuminate\Queue\SerializesModels;
|
|
use Illuminate\Support\Facades\Cache;
|
|
use Illuminate\Support\Facades\Log;
|
|
|
|
class CleanupInstanceStuffsJob implements ShouldBeEncrypted, ShouldBeUnique, ShouldQueue
|
|
{
|
|
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
|
|
|
|
public $timeout = 60;
|
|
|
|
public function __construct() {}
|
|
|
|
public function middleware(): array
|
|
{
|
|
return [(new WithoutOverlapping('cleanup-instance-stuffs'))->expireAfter(60)->dontRelease()];
|
|
}
|
|
|
|
public function handle(): void
|
|
{
|
|
try {
|
|
$this->cleanupInvitationLink();
|
|
$this->cleanupExpiredEmailChangeRequests();
|
|
$this->enforceBackupRetention();
|
|
} catch (\Throwable $e) {
|
|
Log::error('CleanupInstanceStuffsJob failed with error: '.$e->getMessage());
|
|
}
|
|
}
|
|
|
|
private function cleanupInvitationLink()
|
|
{
|
|
$invitation = TeamInvitation::all();
|
|
foreach ($invitation as $item) {
|
|
$item->isValid();
|
|
}
|
|
}
|
|
|
|
private function cleanupExpiredEmailChangeRequests()
|
|
{
|
|
User::whereNotNull('email_change_code_expires_at')
|
|
->where('email_change_code_expires_at', '<', now())
|
|
->update([
|
|
'pending_email' => null,
|
|
'email_change_code' => null,
|
|
'email_change_code_expires_at' => null,
|
|
]);
|
|
}
|
|
|
|
private function enforceBackupRetention(): void
|
|
{
|
|
if (! Cache::add('backup-retention-enforcement', true, 1800)) {
|
|
return;
|
|
}
|
|
|
|
try {
|
|
$backups = ScheduledDatabaseBackup::where('enabled', true)->get();
|
|
foreach ($backups as $backup) {
|
|
try {
|
|
removeOldBackups($backup);
|
|
} catch (\Throwable $e) {
|
|
Log::warning('Failed to enforce retention for backup '.$backup->id.': '.$e->getMessage());
|
|
}
|
|
}
|
|
} catch (\Throwable $e) {
|
|
Log::error('Failed to enforce backup retention: '.$e->getMessage());
|
|
Cache::forget('backup-retention-enforcement');
|
|
}
|
|
}
|
|
}
|