6488751fd2
- Store proxy configuration in database as primary source for faster access - Implement automatic timestamped backups when configuration changes - Add backfill migration logic to recover configs from disk for legacy servers - Simplify UI by removing loading states (config now readily available) - Add comprehensive logging for debugging configuration generation and recovery - Include unit tests for config recovery scenarios
109 lines
3.6 KiB
PHP
109 lines
3.6 KiB
PHP
<?php
|
|
|
|
use App\Actions\Proxy\GetProxyConfiguration;
|
|
use Illuminate\Support\Facades\Cache;
|
|
use Illuminate\Support\Facades\Log;
|
|
use Spatie\SchemalessAttributes\SchemalessAttributes;
|
|
|
|
beforeEach(function () {
|
|
Log::spy();
|
|
Cache::spy();
|
|
});
|
|
|
|
function mockServerWithDbConfig(?string $savedConfig): object
|
|
{
|
|
$proxyAttributes = Mockery::mock(SchemalessAttributes::class);
|
|
$proxyAttributes->shouldReceive('get')
|
|
->with('last_saved_proxy_configuration')
|
|
->andReturn($savedConfig);
|
|
|
|
$server = Mockery::mock('App\Models\Server');
|
|
$server->shouldIgnoreMissing();
|
|
$server->shouldReceive('getAttribute')->with('proxy')->andReturn($proxyAttributes);
|
|
$server->shouldReceive('getAttribute')->with('id')->andReturn(1);
|
|
$server->shouldReceive('getAttribute')->with('name')->andReturn('Test Server');
|
|
$server->shouldReceive('proxyType')->andReturn('TRAEFIK');
|
|
$server->shouldReceive('proxyPath')->andReturn('/data/coolify/proxy');
|
|
|
|
return $server;
|
|
}
|
|
|
|
it('returns OK for NONE proxy type without reading config', function () {
|
|
$server = Mockery::mock('App\Models\Server');
|
|
$server->shouldIgnoreMissing();
|
|
$server->shouldReceive('proxyType')->andReturn('NONE');
|
|
|
|
$result = GetProxyConfiguration::run($server);
|
|
|
|
expect($result)->toBe('OK');
|
|
});
|
|
|
|
it('reads proxy configuration from database', function () {
|
|
$savedConfig = "services:\n traefik:\n image: traefik:v3.5\n";
|
|
$server = mockServerWithDbConfig($savedConfig);
|
|
|
|
// ProxyDashboardCacheService is called at the end — mock it
|
|
$server->shouldReceive('proxyType')->andReturn('TRAEFIK');
|
|
|
|
$result = GetProxyConfiguration::run($server);
|
|
|
|
expect($result)->toBe($savedConfig);
|
|
});
|
|
|
|
it('preserves full custom config including labels, env vars, and custom commands', function () {
|
|
$customConfig = <<<'YAML'
|
|
services:
|
|
traefik:
|
|
image: traefik:v3.5
|
|
command:
|
|
- '--entrypoints.http.address=:80'
|
|
- '--metrics.prometheus=true'
|
|
labels:
|
|
- 'traefik.enable=true'
|
|
- 'waf.custom.middleware=true'
|
|
environment:
|
|
CF_API_EMAIL: user@example.com
|
|
CF_API_KEY: secret-key
|
|
YAML;
|
|
|
|
$server = mockServerWithDbConfig($customConfig);
|
|
|
|
$result = GetProxyConfiguration::run($server);
|
|
|
|
expect($result)->toBe($customConfig)
|
|
->and($result)->toContain('waf.custom.middleware=true')
|
|
->and($result)->toContain('CF_API_EMAIL')
|
|
->and($result)->toContain('metrics.prometheus=true');
|
|
});
|
|
|
|
it('logs warning when regenerating defaults', function () {
|
|
Log::swap(new \Illuminate\Log\LogManager(app()));
|
|
Log::spy();
|
|
|
|
// No DB config, no disk config — will try to regenerate
|
|
$server = mockServerWithDbConfig(null);
|
|
|
|
// backfillFromDisk will be called — we need instant_remote_process to return empty
|
|
// Since it's a global function we can't easily mock it, so test the logging via
|
|
// the force regenerate path instead
|
|
try {
|
|
GetProxyConfiguration::run($server, forceRegenerate: true);
|
|
} catch (\Throwable $e) {
|
|
// generateDefaultProxyConfiguration may fail without full server setup
|
|
}
|
|
|
|
Log::shouldHaveReceived('warning')
|
|
->withArgs(fn ($message) => str_contains($message, 'regenerated to defaults'))
|
|
->once();
|
|
});
|
|
|
|
it('does not read from disk when DB config exists', function () {
|
|
$savedConfig = "services:\n traefik:\n image: traefik:v3.5\n";
|
|
$server = mockServerWithDbConfig($savedConfig);
|
|
|
|
// If disk were read, instant_remote_process would be called.
|
|
// Since we're not mocking it and the test passes, it proves DB is used.
|
|
$result = GetProxyConfiguration::run($server);
|
|
|
|
expect($result)->toBe($savedConfig);
|
|
});
|