Reduce unnecessary job queue pressure and improve subscription sync reliability: - Cache ServerStorageCheckJob dispatch to only trigger on disk percentage changes - Rate-limit ConnectProxyToNetworksJob to maximum once per 10 minutes - Add progress callback support to SyncStripeSubscriptionsJob for UI feedback - Implement bulk fetching of valid Stripe subscription IDs for efficiency - Detect and report resubscribed users (same email, different customer ID) - Fix CleanupUnreachableServers query operator (>= 3 instead of = 3) - Improve empty subId validation in PushServerUpdateJob - Optimize relationship access by using properties instead of query methods - Add comprehensive test coverage for all optimizations
73 lines
2.1 KiB
PHP
73 lines
2.1 KiB
PHP
<?php
|
|
|
|
use App\Models\Server;
|
|
use App\Models\Team;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('cleans up servers with unreachable_count >= 3 after 7 days', function () {
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create([
|
|
'team_id' => $team->id,
|
|
'unreachable_count' => 50,
|
|
'unreachable_notification_sent' => true,
|
|
'updated_at' => now()->subDays(8),
|
|
]);
|
|
|
|
$this->artisan('cleanup:unreachable-servers')->assertSuccessful();
|
|
|
|
$server->refresh();
|
|
expect($server->ip)->toBe('1.2.3.4');
|
|
});
|
|
|
|
it('does not clean up servers with unreachable_count less than 3', function () {
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create([
|
|
'team_id' => $team->id,
|
|
'unreachable_count' => 2,
|
|
'unreachable_notification_sent' => true,
|
|
'updated_at' => now()->subDays(8),
|
|
]);
|
|
|
|
$originalIp = $server->ip;
|
|
|
|
$this->artisan('cleanup:unreachable-servers')->assertSuccessful();
|
|
|
|
$server->refresh();
|
|
expect($server->ip)->toBe($originalIp);
|
|
});
|
|
|
|
it('does not clean up servers updated within 7 days', function () {
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create([
|
|
'team_id' => $team->id,
|
|
'unreachable_count' => 10,
|
|
'unreachable_notification_sent' => true,
|
|
'updated_at' => now()->subDays(3),
|
|
]);
|
|
|
|
$originalIp = $server->ip;
|
|
|
|
$this->artisan('cleanup:unreachable-servers')->assertSuccessful();
|
|
|
|
$server->refresh();
|
|
expect($server->ip)->toBe($originalIp);
|
|
});
|
|
|
|
it('does not clean up servers without notification sent', function () {
|
|
$team = Team::factory()->create();
|
|
$server = Server::factory()->create([
|
|
'team_id' => $team->id,
|
|
'unreachable_count' => 10,
|
|
'unreachable_notification_sent' => false,
|
|
'updated_at' => now()->subDays(8),
|
|
]);
|
|
|
|
$originalIp = $server->ip;
|
|
|
|
$this->artisan('cleanup:unreachable-servers')->assertSuccessful();
|
|
|
|
$server->refresh();
|
|
expect($server->ip)->toBe($originalIp);
|
|
});
|