rosslh/coolify
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
coolify/tests/Feature
History
Andras Bacsai 56a0143a25 Fix: Prevent ServerStorageCheckJob duplication when Sentinel is active 
When Sentinel is enabled and in sync, ServerStorageCheckJob was being
dispatched from two locations causing unnecessary duplication:
1. PushServerUpdateJob (every ~30s with real-time filesystem data)
2. ServerManagerJob (scheduled cron check via SSH)

This commit modifies ServerManagerJob to only dispatch ServerStorageCheckJob
when Sentinel is out of sync or disabled. When Sentinel is active and in sync,
PushServerUpdateJob provides real-time storage data, making the scheduled SSH
check redundant.

Benefits:
- Eliminates duplicate storage checks when Sentinel is working
- Reduces unnecessary SSH overhead
- Storage checks still run as fallback when Sentinel fails
- Maintains scheduled checks for servers without Sentinel

Updated tests to reflect new behavior:
- Storage check NOT dispatched when Sentinel is in sync
- Storage check dispatched when Sentinel is out of sync or disabled
- All timezone and frequency tests updated accordingly

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-12-03 10:05:10 +01:00
..
Service feat: Implement required port validation for service applications 2025-11-06 14:32:36 +01:00
ApplicationBuildpackCleanupTest.php refactor: move buildpack cleanup logic to model lifecycle hooks 2025-11-18 10:29:08 +01:00
BuildpackSwitchCleanupTest.php refactor: move buildpack cleanup logic to model lifecycle hooks 2025-11-18 10:29:08 +01:00
CheckTraefikVersionJobTest.php Fix Traefik email notification with clickable server links 2025-12-02 13:08:40 +01:00
CleanupRedisTest.php fix(CleanupRedisTest): update mock return values for hgetall to reflect job processing state 2025-11-11 23:17:25 +01:00
CloudInitScriptTest.php feat: add cloud-init script support for Hetzner server creation 2025-10-10 19:37:16 +02:00
ConvertArraysTest.php fix: check if array is associative or not 2024-09-03 17:04:56 +02:00
ConvertContainerEnvsToArray.php chore(tests): update test environment database name and add new feature test for converting container environment variables to array 2025-05-22 14:30:16 +02:00
ConvertingGitUrlsTest.php fix: add tests for git url converts 2024-11-12 11:32:18 +01:00
CoolifyTaskRetryTest.php feat(jobs): improve scheduled tasks with retry logic and queue cleanup 2025-11-10 11:11:18 +01:00
DatabaseBackupCreationApiTest.php feat: Implement required port validation for service applications 2025-11-06 14:32:36 +01:00
DatabaseBackupJobTest.php feat(backup): enhance backup job with S3 upload handling and notifications 2025-10-07 15:02:23 +02:00
DeletesUserSessionsTest.php Changes auto-committed by Conductor 2025-10-16 09:51:37 +02:00
DeploymentCancellationApiTest.php Changes auto-committed by Conductor 2025-10-16 11:01:58 +02:00
DockerCustomCommandsTest.php fix: handle escaped quotes in docker entrypoint parsing 2025-11-03 21:10:32 +00:00
EnvironmentVariableSharedSpacingTest.php test: add tests for shared environment variable spacing and resolution 2025-11-27 10:45:39 +01:00
ExecuteContainerCommandTest.php test: setup database for upcoming tests 2024-12-04 12:43:52 +01:00
GithubAppsListApiTest.php Changes auto-committed by Conductor 2025-10-16 13:19:05 +02:00
GithubSourceChangeTest.php fix: GitHub source creation and configuration issues 2025-10-25 10:49:09 +02:00
GithubSourceCreateTest.php fix: GitHub source creation and configuration issues 2025-10-25 10:49:09 +02:00
HetznerServerCreationTest.php fix: update boarding flow logic to complete onboarding when server is created 2025-10-29 23:06:39 +01:00
IpAllowlistTest.php refactor(dns-validation): rename DNS validation functions for consistency and clarity, and remove unused code 2025-09-09 09:00:35 +02:00
LoginRateLimitIPTest.php rate limit test 2025-10-28 15:18:28 +01:00
MultilineEnvironmentVariableTest.php feat(deployments): enhance Docker build argument handling for multiline variables 2025-10-02 13:54:36 +02:00
ServerPatchCheckNotificationTest.php test: fix ServerPatchCheckNotification tests to avoid global state pollution 2025-10-26 21:54:55 +01:00
ServerSettingSentinelRestartTest.php Changes auto-committed by Conductor 2025-10-16 09:51:37 +02:00
ServerSettingWasChangedTest.php Changes auto-committed by Conductor 2025-10-16 09:51:37 +02:00
ServerStorageCheckIndependenceTest.php Fix: Prevent ServerStorageCheckJob duplication when Sentinel is active 2025-12-03 10:05:10 +01:00
ServiceFqdnUpdatePathTest.php fix: prevent SERVICE_FQDN/SERVICE_URL path duplication on FQDN updates 2025-11-27 10:57:24 +01:00
StartupExecutionCleanupTest.php feat(Cleanup): implement failure marking for stuck scheduled tasks and database backups during startup 2025-11-11 12:32:52 +01:00
TeamInvitationEmailNormalizationTest.php refactor(ui): improve styling and consistency in environment variable warning and docker cleanup components 2025-09-25 11:45:07 +02:00
TeamInvitationPrivilegeEscalationTest.php fix: critical privilege escalation in team invitation system 2025-10-15 11:42:25 +02:00
TeamPolicyTest.php fix: add authentication context to TeamPolicyTest 2025-10-15 15:08:35 +02:00
TrustHostsMiddlewareTest.php Changes auto-committed by Conductor 2025-10-20 09:48:37 +02:00
Utf8HandlingTest.php feat(utf8-handling): implement UTF-8 sanitization for command outputs and enhance error handling in logs processing 2025-06-05 14:27:39 +02:00