06ee7d0132
Fixed multiple issues with GitHub App source creation and management: 1. **Fixed null property assignment error on component mount** - Changed property types to nullable in Change component (appId, installationId, clientId, etc.) - Updated validation rules to allow nullable values - Allows mounting component with newly created GitHub Apps that don't have these fields set yet 2. **Fixed Livewire morphing error on manual creation** - Modified createGithubAppManually() to redirect after saving - Prevents "Cannot read properties of null" error when view structure changes - Fields now properly populated after manual creation without requiring page refresh 3. **Fixed is_system_wide not being saved on creation** - Removed backwards logic that only saved is_system_wide on cloud instances - Added is_system_wide to GithubApp model casts for proper boolean handling - System-wide checkbox now works correctly on self-hosted instances 4. **Fixed misleading preview deployment checkbox** - Removed instantSave attribute from permission checkboxes in unconfigured state - These are configuration options for GitHub App creation, not database fields - Prevents "GitHub App updated" success message when nothing was actually saved 5. **Added validation for Refetch Permissions button** - Validates App ID and Private Key are set before attempting to fetch - Shows clear error messages: "Cannot fetch permissions. Please set the following required fields first: App ID, Private Key" - Prevents crash when private key is null or invalid 6. **Better error handling for unsupported private key formats** - Detects OpenSSH format keys vs RSA PEM format - Shows helpful message: "Please use an RSA private key in PEM format (BEGIN RSA PRIVATE KEY). OpenSSH format keys are not supported." - GitHub Apps require RSA PEM format, not OpenSSH format 7. **Made GitHub App view mobile responsive** - Updated all flex layouts to stack vertically on mobile (flex-col sm:flex-row) - Form fields, buttons, and sections now properly responsive - No more cut-off fields on small screens Added comprehensive test coverage: - GithubSourceChangeTest.php with 7 tests - GithubSourceCreateTest.php with 6 tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
66 lines
1.9 KiB
PHP
66 lines
1.9 KiB
PHP
<?php
|
|
|
|
namespace App\Livewire\Source\Github;
|
|
|
|
use App\Models\GithubApp;
|
|
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
|
|
use Livewire\Component;
|
|
|
|
class Create extends Component
|
|
{
|
|
use AuthorizesRequests;
|
|
|
|
public string $name;
|
|
|
|
public ?string $organization = null;
|
|
|
|
public string $api_url = 'https://api.github.com';
|
|
|
|
public string $html_url = 'https://github.com';
|
|
|
|
public string $custom_user = 'git';
|
|
|
|
public int $custom_port = 22;
|
|
|
|
public bool $is_system_wide = false;
|
|
|
|
public function mount()
|
|
{
|
|
$this->name = substr(generate_random_name(), 0, 30);
|
|
}
|
|
|
|
public function createGitHubApp()
|
|
{
|
|
try {
|
|
$this->authorize('createAnyResource');
|
|
|
|
$this->validate([
|
|
'name' => 'required|string',
|
|
'organization' => 'nullable|string',
|
|
'api_url' => 'required|string',
|
|
'html_url' => 'required|string',
|
|
'custom_user' => 'required|string',
|
|
'custom_port' => 'required|int',
|
|
'is_system_wide' => 'required|bool',
|
|
]);
|
|
$payload = [
|
|
'name' => $this->name,
|
|
'organization' => $this->organization,
|
|
'api_url' => $this->api_url,
|
|
'html_url' => $this->html_url,
|
|
'custom_user' => $this->custom_user,
|
|
'custom_port' => $this->custom_port,
|
|
'is_system_wide' => $this->is_system_wide,
|
|
'team_id' => currentTeam()->id,
|
|
];
|
|
$github_app = GithubApp::create($payload);
|
|
if (session('from')) {
|
|
session(['from' => session('from') + ['source_id' => $github_app->id]]);
|
|
}
|
|
|
|
return redirect()->route('source.github.show', ['github_app_uuid' => $github_app->uuid]);
|
|
} catch (\Throwable $e) {
|
|
return handleError($e, $this);
|
|
}
|
|
}
|
|
}
|